PR: Change default format in array editor to ''
#22484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the default format in the array editor for non-numeric arrays was set to 's'. This meant that ArrayModel.data() returned a value of type numpy.str_ for string arrays instead of a value of type str. The consequence was that the contents of the array were not shown. Changing the default format to '' fixes this. Also add a regression test.
jitseniesen
force-pushed
the
string-array
branch
from
4eee3e1
to
ed46ef7
Compare
ccordoba12
approved these changes
Sep 11, 2024
ccordoba12
changed the title
''
|
@meeseeksdev please backport to 6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/spyder
that referenced
this pull request
Sep 11, 2024
ccordoba12
pushed a commit
that referenced
this pull request
Sep 11, 2024
…editor to `''`) (#22488) Co-authored-by: Jitse Niesen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Before, the default format in the array editor for non-numeric arrays was set to 's'. This meant that ArrayModel.data() returned a value of type numpy.str_ for string arrays instead of a value of type str. The consequence was that the contents of the array were not shown.
This PR changes the default format to '' to fix this. It also adds a regression test.
Issue(s) Resolved
Fixes #22466
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
Jitse Niesen