PR: Provide username, host and port from hostname info in ssh tunnels #22691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo in ssh tunnels
ccordoba12
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Thanks @hlouzada for your work on this! I only left a couple of simple suggestions for you.
Tomorrow I'll give this a manual check.
ccordoba12
changed the title
ccordoba12
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
I tested this manually and it works like a charm, thanks @hlouzada!
|
@meeseeksdev please backport to 6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/spyder
that referenced
this pull request
Oct 28, 2024
…m hostname info in ssh tunnels
ccordoba12
pushed a commit
that referenced
this pull request
Oct 28, 2024
… from hostname info in ssh tunnels) (#22749)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Split ssh address into host and port provided from the external kernel connections dialog to ssh tunneling handler.
Issue(s) Resolved
Fixes #22555
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @hlouzada