Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix enabled state of Run plugin actions when a file type doesn't have an associated configuration #22819

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • This problem occurred, for instance, when the last file to receive focus after Spyder started was a Markdown one. And that's because those files don't have a run configuration associated to them by default.
  • Also, improve a couple of block comments in BaseEditMixin.

Issue(s) Resolved

Fixes #22607

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v6.0.3 milestone Nov 3, 2024
@ccordoba12 ccordoba12 self-assigned this Nov 3, 2024
@ccordoba12 ccordoba12 merged commit 0e71cda into spyder-ide:master Nov 3, 2024
17 checks passed
@ccordoba12 ccordoba12 deleted the issue-22607 branch November 3, 2024 02:21
@ccordoba12
Copy link
Member Author

@meeseeksdev please backport to 6.x

Copy link

lumberbot-app bot commented Nov 3, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 0e71cda83cf4cfdeef17e63a485598801f66f40e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am "Backport PR #22819: PR: Fix enabled state of Run plugin actions when a file type doesn't have an associated configuration"
  1. Push to a named branch:
git push YOURFORK 6.x:auto-backport-of-pr-22819-on-6.x
  1. Create a PR against branch 6.x, I would have named this PR:

"Backport PR #22819 on branch 6.x (PR: Fix enabled state of Run plugin actions when a file type doesn't have an associated configuration)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

ccordoba12 added a commit to ccordoba12/spyder that referenced this pull request Nov 3, 2024
…ions when a file type doesn't have an associated configuration
ccordoba12 added a commit that referenced this pull request Nov 3, 2024
… actions when a file type doesn't have an associated configuration) (#22821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError problem when running files
1 participant