Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite 3.45.2 #581

Merged
merged 2 commits into from
Apr 14, 2024
Merged

sqlite 3.45.2 #581

merged 2 commits into from
Apr 14, 2024

Conversation

lovasoa
Copy link
Member

@lovasoa lovasoa commented Apr 14, 2024

No description provided.

@lovasoa lovasoa merged commit d58d741 into master Apr 14, 2024
2 checks passed
@lovasoa lovasoa deleted the sqlite3.45.2 branch April 14, 2024 08:41
@lovasoa lovasoa restored the sqlite3.45.2 branch April 14, 2024 08:46
@james-bowers
Copy link

james-bowers commented Apr 15, 2024

Hi @lovasoa - is there any chance this has overwritten the wasm at https://sql.js.org/dist/sql-wasm.wasm ? We've found that the exec function on 1.10.2 broke but using 1.10.3 fixes it, and as the call to load the wasm isn't versioned this might explain the break.

We haven't changed the version in a couple of months and this looks like a possible suspect to cause the breakage, but I may well be wrong!

@lovasoa lovasoa deleted the sqlite3.45.2 branch April 15, 2024 13:00
@lovasoa
Copy link
Member Author

lovasoa commented Apr 15, 2024

Hi ! Indeed, sql.js has been updated yesterday. The official sql.js.org website always hosts the latest version (since yesterday, 1.10.3, which uses SQLite 3.45.2).

If you depend on sql.js in production, you probably should host it, sql.js.org doesn't come with any versioning or availability guarantees.

@lovasoa
Copy link
Member Author

lovasoa commented Apr 15, 2024

And if you found a bug in sql.js, you should report it !

@james-bowers
Copy link

james-bowers commented Apr 15, 2024

OK thanks @lovasoa - is it just the one wasm file I need to host? The readme makes it look like there might be multiple with this example:

  locateFile: file => `https://sql.js.org/dist/${file}`

but the network requests look to only load in;

https://sql.js.org/dist/sql-wasm.wasm

@lovasoa
Copy link
Member Author

lovasoa commented Apr 15, 2024

In the wasm case, there is only this file.
If you want something future proof, expose the entire dist folder from the npm package

@james-bowers
Copy link

In the wasm case, there is only this file. If you want something future proof, expose the entire dist folder from the npm package

Got it - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants