Fix 'alembic check' with multidb env #1365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spladug
force-pushed
the
check-command-for-multidb-env
branch
from
c1bb019
to
fc9be86
Compare
sqla-tester
reviewed
Nov 22, 2023
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision fc9be86 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change fc9be86: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4979 |
|
Federico Caselli (CaselIT) wrote: great work, also the test! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4979 |
|
mike bayer (zzzeek) wrote: thanks for getting this in for us! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4979 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4979 has been merged. Congratulations! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1234
Description
This fixes
alembic checkfor multi-db environments by combining diffs from all ops in theupgrade_ops_listrather than assuming it's single-db and usingupgrade_ops. The new tests reuse the actual checks from the single-db case but override the env setup so any future single-dbchecktests are automatically applied to the multi-db case too.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!