Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add TextClause to alter_column's server_default fields. #1577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanCardin
Copy link
Contributor

Description

Given sqlalchemy models with server_defaults, alembic may autogenerate existing_server_default=sa.text("..."), which fails typechecking on the resultant migration because TextClause is not currently a valid annotated type.

I'm just not sure whether there's a more general type that would make more sense or not. just that given what alembic itself is generating, this should presumably be allowed.

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant