refactor: add revision context to AutogenerateDiffsDetected so that wrappers may make other formatting of the diff #1598
Conversation
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision ee7d8de of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change ee7d8de: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 |
…rappers may make other formatting of the diff fixes: sqlalchemy#1597
lachaib
force-pushed
the
lachaib/issue1597
branch
from
ee7d8de to
7799320
Compare
|
Thanks for the update, will run the full ci now! |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 7799320 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 7799320 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 |
|
Michael Bayer (zzzeek) wrote: recheck black is still being weird even though this is an updated python 3.12 version, I was able to repro that failure on the jenkins node, then I ran tools/write_pyi on the files, and nothing changed, then the tests started passing without needing to reformat the files. so there's something fishy here for sure. black has some kind of caching / state somewhere which I would assume is involved here View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 |
|
Michael Bayer (zzzeek) wrote: OK it's good thanks! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 has been merged. Congratulations! :) |
…rappers may make other formatting of the diff ### Description As discussed in #1597, AutogenerateDiffsDetected should hold contextual information so that command can be wrapped for another format (CI, pre-commit hook...) ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once) --> This pull request is: - [ ] A documentation / typographical error fix - Good to go, no issue or tests are needed - [x] A short code fix - please include the issue number, and create an issue if none exists, which must include a complete example of the issue. one line code fixes without an issue and demonstration will not be accepted. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. one line code fixes without tests will not be accepted. - [ ] A new feature implementation - please include the issue number, and create an issue if none exists, which must include a complete example of how the feature would look. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. **Have a nice day!** Closes: #1598 Pull-request: sqlalchemy/alembic#1598 Pull-request-sha: 7799320ad3c1a1bd769254d610288c97f85cb345 Change-Id: Id08bc52a0586063f177736a36a61f96232459f1c
Description
As discussed in #1597, AutogenerateDiffsDetected should hold contextual information so that command can be wrapped for another format (CI, pre-commit hook...)
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!