support 'append_delimiter' to fix #1679 #1680
Conversation
|
do we want to add a test? |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 8c0f417 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 8c0f417: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5989 |
I couldn't find any test that covered an existing |
|
i dont care about a test but it should have a changelog |
|
updated with changelog. |
|
you placed the changelog in the changelog file, not in a separated fragment. I'm sure if it will cause issues when the changelog gets rendered. cc @zzzeek |
Where should it go? The build here is different than sqlalchemy and I couldn't find instructions. Happy to make it conform. |
|
like sqlalchemy, it should be a file in https://github.com/sqlalchemy/alembic/tree/main/docs/build/unreleased like #1672 (comment) |
|
Ah, sorry - I didn't see that directory. SQLAlchemy has instructions here:
Alembic has them hidden, like this:
|
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 20b2aca of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 20b2aca added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5989 |
|
Michael Bayer (zzzeek) wrote: pep8-recheck View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5989 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5989 has been merged. Congratulations! :) |
Fixed rendering of ``pyproject.toml`` to include two newlines when appending content to an existing file. Pull request courtesy Jonathan Vanasco. Co-authored-by: Mike Bayer <[email protected]> Fixes: #1679 Closes: #1680 Pull-request: sqlalchemy/alembic#1680 Pull-request-sha: 20b2aca0d2f6a8f5957063b950e45874343e9a99 Change-Id: Ic2e76a3f791dbda0bd61f09a2c7bafbcdab5eb7f
Adds an "append_delimiter" kwarg and checks the existing file to see if it is required.
There are likely better ways to handle this fix against #1679.