Use jackc/pgtype #1135
Closed
Use jackc/pgtype #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pgtype package contains Go types for over 70 PostgreSQL types. It's used heavily inside of pgx. Each type is also tested against lib/pq.
I'm still not 100% I'm going to make this change. It introduces a dependency on an external package for generated code that could change at any time. There's no easy way to declare which version of the package that the generated code should use.
That said, the current behavior around many of these types is broken. Scanning a NULL value into a
json.RawMessagejust doesn't work. The same goes for MAC addresses, IP addresses, and more. The goal is to add support for all 70 types in this PR, including end-to-end tests to verify that things work against a running PostgreSQL database.Fixes #739