GitHub #102 - Scene isActive now always returns null

sqmk · Oct 17, 2016 · 6049929 · 6049929
1 parent 1a389ae
commit 6049929
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 16 deletions.
diff --git a/examples/list-scenes.php b/examples/list-scenes.php
@@ -11,6 +11,6 @@
 echo 'Listing scenes:', "\n";
 
 foreach ($client->getScenes() as $scene) {
-    echo "\t", "#{$scene->getId()} - {$scene->getName()}", "\n", "\t\t", "Light Ids: ", implode(
-        ', ', $scene->getLightIds()), "\n", "\t\t", "Is active: ", $scene->isActive() ? 'Yes' : 'No', "\n";
+    echo "\t", "#{$scene->getId()} - {$scene->getName()}", "\n",
+        "\t\t", "Light Ids: ", implode(', ', $scene->getLightIds()), "\n";
 }
diff --git a/library/Phue/Scene.php b/library/Phue/Scene.php
@@ -85,11 +85,13 @@ public function getLightIds()
     /**
      * Is active
      *
-     * @return bool True if active, false if not
+     * @deprecated
+     *
+     * @return null This is now deprecated
      */
     public function isActive()
     {
-        return (bool) $this->attributes->active;
+        return null;
     }
 
     /**

diff --git a/tests/Phue/Test/SceneTest.php b/tests/Phue/Test/SceneTest.php
@@ -39,8 +39,7 @@ public function setUp()
                 2,
                 3,
                 5
-            ),
-            'active' => true
+            )
         );
 
         // Create scene object
@@ -77,16 +76,6 @@ public function testGetLightIds()
         $this->assertEquals($this->attributes->lights, $this->scene->getLightIds());
     }
 
-    /**
-     * Test: Is active
-     *
-     * @covers \Phue\Scene::isActive
-     */
-    public function testIsActive()
-    {
-        $this->assertEquals($this->attributes->active, $this->scene->isActive());
-    }
-
     /**
      * Test: toString
      *