This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Exit with failure when an error occured while connecting to mongod. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the exeption being caught and ignored, letting the process hang in an unusable state.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the exception being caught and ignored, letting the process hang in an unusable state.
This is particularly important when starting mongod, the cube collector and evaluator via supervisord. If the process does not exit with failure, supervisord will never restart the collector and evaluator and the connection to mongod will never happen.
And, in general, there is no point in keeping the collector and evaluator running if there is no connection to mongod.
Thanks!