This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Stream feature for metric #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch for 'start' in ...
|
@mbostock |
|
Some minor changes made the test pass successfully. |
|
@mbostock it would be useful for us, is there any issue with this pullrequest ? |
|
We are using this, and it seems to work as advertised. Good job @gravitezero! When can we see this in master? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, I finish the stream feature for metric as well.
The design is quite different from events.
It was too complicated to share the polling loop, so there is one loop for each client.
A better solution can surely be found, but I don't understand cube enough nor have time to implement it for the moment.