Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Solution to #60 #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution to #60 #80

wants to merge 1 commit into from

Conversation

mmmulani
Copy link

@mmmulani mmmulani commented Jul 7, 2012

Add a parameter to /event/get to toggle retrieving all event data.
The parameter is "allData" and when present, all fields of the event are returned regardless of what is specified. (i.e. the query "expression=server(cpu)&allData" will return all fields)

While this creates another parameter rather than allowing a query like "server(*)", it is explicit in that it is a switch to return all data.

@mbostock
Copy link
Collaborator

mbostock commented Jul 8, 2012

Related #60.

I would rather this be implemented as a wildcard operator, rather than adding a new query parameter.

@mmmulani
Copy link
Author

mmmulani commented Jul 9, 2012

Yeah that would be nicer, I'll try hacking it out today.

My idea is to only allow "type()" rather than also allow "type(prop.)" since that can be queried by "type(prop)"

@mbostock
Copy link
Collaborator

mbostock commented Jul 9, 2012

Yes, I agree: type(*). You can already get type(prop.*) by saying type(prop).

@mmmulani
Copy link
Author

mmmulani commented Jul 9, 2012

Sorry about the huge size, that's from me regenerating the grammar with pegjs.

I had to reorder the grammar rules, looks like pegjs eagerly fails as soon as it starts matching a subrule in the grammar.

@edmund-huber
Copy link

Why not just have a query like "event" return all data for all events called "event"?

@mmmulani
Copy link
Author

@edmund-huber there is definitely value in the knowledge that an event simply occurred (and overhead in sending down/calculating all those properties)
having "type" return all data for all events called "type" also makes "sum(type)" confusing as it doesn't act on any of the properties.

@mbostock
Copy link
Collaborator

Right, we want the event expression "event" to only return the event times—it's an existence check.

@mmmulani
Copy link
Author

@mbostock how does this diff look? seems to work for me..

dspinoz added a commit to dspinoz/cube that referenced this pull request Apr 13, 2017
…k, stat.net. Events are stored with main type (up to first dot), and then a data field containing subtype. square#80
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants