Skip to content
This repository was archived by the owner on Nov 22, 2023. It is now read-only.

Update dropwizard-raven library so it conforms to dropwizard 1.2.x API#389

Merged
mbyczkowski merged 1 commit intomasterfrom
mbyczkowski/update-raven
Nov 1, 2018
Merged

Update dropwizard-raven library so it conforms to dropwizard 1.2.x API#389
mbyczkowski merged 1 commit intomasterfrom
mbyczkowski/update-raven

Conversation

@mbyczkowski
Copy link
Contributor

It seems that github.com/tradier/dropwizard-raven has stopped receiving updates
(particularly there's a
PR that
specifically makes the lib compatible with dropwizard 1.2.x that has not
been merged since Nov 7, 2017). The maintenance work continues in the
fork and there's one 1.2.x JAR
release under org.dhatim.dropwizard-raven. The project has seen been
renamed to dropwizard-sentry and new versions of the library (1.3.x+)
are published under org.dhatim.dropwizard-sentry, which I have noted in
the comments.

It seems that github.com/tradier/dropwizard-raven has stopped receiving updates
(particularly there's a
[PR](tradier/dropwizard-raven#20) that
specifically makes the lib compatible with dropwizard 1.2.x that has not
been merged since Nov 7, 2017). The maintenance work continues in the
[fork](github.com/dhatim/dropwizard-sentry) and there's one 1.2.x JAR
release under org.dhatim.dropwizard-raven. The project has seen been
renamed to dropwizard-sentry and new versions of the library (1.3.x+)
are published under org.dhatim.dropwizard-sentry, which I have noted in
the comments.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.209% when pulling 4a25a13 on mbyczkowski/update-raven into 6215cd2 on master.

Copy link
Contributor

@jbpeirce jbpeirce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, I'd like to see this moved to https://github.com/dhatim/dropwizard-sentry or another Sentry module that's better-maintained; for now, though, we can minimize changes.

@mbyczkowski
Copy link
Contributor Author

@jbpeirce this is using exactly https://github.com/dhatim/dropwizard-sentry, however the first release (1.2.0-1) was published as org.dhatim.dropwizard-raven and every other release after that was published as org.dhatim.dropwizard-sentry. I decided to use the org.dhatim.dropwizard-raven JAR because we use dropwizard 1.2.9. It definitely makes sense to bump this lib once we upgrade to dropwizard 1.3.x.

@mbyczkowski mbyczkowski merged commit bd6f5eb into master Nov 1, 2018
@mbyczkowski mbyczkowski deleted the mbyczkowski/update-raven branch November 1, 2018 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants