Skip to content

Added OSGi metadata via build#3477

Open
swimmesberger wants to merge 2 commits intosquare:trunkfrom
swimmesberger:osgi_metadata
Open

Added OSGi metadata via build#3477
swimmesberger wants to merge 2 commits intosquare:trunkfrom
swimmesberger:osgi_metadata

Conversation

@swimmesberger
Copy link
Copy Markdown

This is analogous to the implementation in square/okhttp#6282

For retrofit there are currently following issues:

  • okhttp/okio is still on a version which do not have OSGi metadata (therefore the test fails)
  • The kotlinx.coroutines (https://github.com/Kotlin/kotlinx.coroutines) stuff is not OSGi compatible, therefore I made those packages optional for now
  • I can't get both "retrofit-converters:guava" and "retrofit-adapters:guava" work together in my test because gradle seems to only copy one of those. It seems as if both of these are defined as project(...) dependencies gradle only adds the first one as an retrievable dependency (maybe a hasdCode/equals conflict?). I have found a similar issue on stackoverflow
  • I can't test moshi/simplexml/wire in the junit test because I haven't found OSGi bundles for those dependencies

@p4535992
Copy link
Copy Markdown

p4535992 commented Feb 2, 2024

+1 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants