Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-change to see if CI is just broken #1273

Closed
wants to merge 3 commits into from
+14 −25
Closed

non-change to see if CI is just broken #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3f67d3
non-change to see if CI is just broken
rjrjr Mar 12, 2025
0c7fc7e
stuff
rjrjr Mar 12, 2025
6a8370a
stop trying to force resolution everywhere
rjrjr Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

Workflow is an application framework that provides architectural primitives.

## fnord

Workflow is:

* Written in and used for Kotlin and Swift
Expand Down
37 changes: 12 additions & 25 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,18 @@ plugins {
}

shardConnectedCheckTasks(project)

subprojects {

afterEvaluate {
configurations.configureEach {
// There could be transitive dependencies in tests with a lower version. This could cause
// problems with a newer Kotlin version that we use.
resolutionStrategy.force(libs.kotlin.reflect)
}
}
}
//
// subprojects {
// // Wait for version catalog to be ready. There is no direct hook, but it happens
// // before base is applied.
// plugins.withId("base") {
// configurations.configureEach {
// // There could be transitive dependencies in tests with a lower version. This could cause
// // problems with a newer Kotlin version that we use.
// resolutionStrategy.force(libs.kotlin.reflect)
// }
// }
// }

apply(from = rootProject.file(".buildscript/binary-validation.gradle"))

Expand Down Expand Up @@ -111,20 +112,6 @@ subprojects {
.configureEach { mustRunAfter(tasks.matching { it is Sign }) }
}

allprojects {

configurations.all {
resolutionStrategy.eachDependency {
// This ensures that any time a dependency has a transitive dependency upon androidx.lifecycle,
// it uses the same version as the rest of the project. This is crucial, since Androidx
// libraries are never in sync and lifecycle 2.4.0 introduced api-breaking changes.
if (requested.group == "androidx.lifecycle") {
useVersion(libs.versions.androidx.lifecycle.get())
}
}
}
}

// This task is invoked by the documentation site generator script in the main workflow project (not
// in this repo), which also expects the generated files to be in a specific location. Both the task
// name and destination directory are defined in this script:
Expand Down
Loading