Merged
Conversation
zach-klippenstein
force-pushed
the
zachklipp/kotlin-2.3.10
branch
from
3fdf36e to
0327e04
Compare
This comment was marked as resolved.
This comment was marked as resolved.
zach-klippenstein
force-pushed
the
zachklipp/kotlin-2.3.10
branch
2 times, most recently
from
fa982e3 to
07f33c1
Compare
zach-klippenstein
force-pushed
the
zachklipp/kotlin-2.3.10
branch
from
07f33c1 to
f870d85
Compare
zach-klippenstein
changed the base branch from
main
to
zachklipp/codeql-workflow
blvckcoded
approved these changes
Feb 12, 2026
Comment on lines
-218
to
-220
| else -> { | ||
| throw IllegalStateException("State can't change while rendering.") | ||
| } |
There was a problem hiding this comment.
how come this compiles? I'm guessing further in the PR there are changes around the renderState?
There was a problem hiding this comment.
Guessing this was just dead code, didn't see related changes in PR
Collaborator
Author
There was a problem hiding this comment.
I am not entirely sure – it looks to me like there are cases this doesn't cover, but if I don't remove this then the compiler complains that it's redundant, so ¯_(ツ)_/¯
Of course, the IDE complains the opposite, but what does it know. I'm guessing it's a K2 thing.
| TakeTurnsProps.resumeGame( | ||
| PlayerInfo("higgledy", "piggledy"), | ||
| output!!.lastTurn | ||
| output.lastTurn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.