Fix display style computation.

This commit fixes a bug where the computed display property of a media resource was not being properly determined. In particular, the isVisible method was only considering the element style attribute of the supplied element and its ancestors.
squat · Nov 7, 2013 · 86d131e · 86d131e
1 parent ee6cbc9
commit 86d131e
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/docs/Postpone.html b/docs/Postpone.html
@@ -2372,7 +2372,7 @@ <h2><a href="index.html">Index</a></h2><h3>Classes</h3><ul><li><a href="Postpone
 <br clear="both">
 
 <footer>
-    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.2.1</a> on Wed Oct 23 2013 19:50:06 GMT-0400 (EDT)
+    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.2.1</a> on Thu Nov 07 2013 11:36:37 GMT-0500 (EST)
 </footer>
 
 <script> prettyPrint(); </script>

diff --git a/docs/global.html b/docs/global.html
@@ -164,7 +164,7 @@ <h2><a href="index.html">Index</a></h2><h3>Classes</h3><ul><li><a href="Postpone
 <br clear="both">
 
 <footer>
-    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.2.1</a> on Wed Oct 23 2013 19:50:06 GMT-0400 (EDT)
+    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.2.1</a> on Thu Nov 07 2013 11:36:37 GMT-0500 (EST)
 </footer>
 
 <script> prettyPrint(); </script>

diff --git a/docs/index.html b/docs/index.html
@@ -54,7 +54,7 @@ <h2><a href="index.html">Index</a></h2><h3>Classes</h3><ul><li><a href="Postpone
 <br clear="both">
 
 <footer>
-    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.2.1</a> on Wed Oct 23 2013 19:50:06 GMT-0400 (EDT)
+    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.2.1</a> on Thu Nov 07 2013 11:36:37 GMT-0500 (EST)
 </footer>
 
 <script> prettyPrint(); </script>

diff --git a/docs/index.js.html b/docs/index.js.html
@@ -361,7 +361,7 @@ <h1 class="page-title">Source: index.js</h1>
      * hidden.
      */
     while ( temp && temp.parentElement && isVisible ) {
-        isVisible = temp.style.display !== "none";
+        isVisible = temp.currentStyle ? temp.currentStyle.display !== "none" : document.defaultView.getComputedStyle( temp ).getPropertyValue( "display" ) !== "none";
         temp = temp.parentElement;
     }
 
@@ -466,7 +466,7 @@ <h2><a href="index.html">Index</a></h2><h3>Classes</h3><ul><li><a href="Postpone
 <br clear="both">
 
 <footer>
-    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.2.1</a> on Wed Oct 23 2013 19:50:06 GMT-0400 (EDT)
+    Documentation generated by <a href="https://github.com/jsdoc3/jsdoc">JSDoc 3.2.1</a> on Thu Nov 07 2013 11:36:37 GMT-0500 (EST)
 </footer>
 
 <script> prettyPrint(); </script>

diff --git a/index.js b/index.js
@@ -334,7 +334,7 @@ Postpone.prototype.isVisible = function( el ) {
      * hidden.
      */
     while ( temp && temp.parentElement && isVisible ) {
-        isVisible = temp.style.display !== "none";
+        isVisible = temp.currentStyle ? temp.currentStyle.display !== "none" : document.defaultView.getComputedStyle( temp ).getPropertyValue( "display" ) !== "none";
         temp = temp.parentElement;
     }