Script does not work for me out of the box... #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squatched
reviewed
Apr 21, 2017
| |`shell`|Creates a tab that| | ||
| |`journalctl, journalctl --follow`|Show only the most recent journal entries, and continuously print new entries as they are appended to the journal.| | ||
| |`home, cd ~ && clear`| Creates a tab, changes directory to your home then clears the console.| | ||
| |`shell【ツ】`|Creates a new shell tab.| |
yakuake-init.sh
Outdated
| # | ||
| logm () | ||
| { | ||
| logger $(trim ${1}) |
There was a problem hiding this comment.
Mind adding a tag for yaukuake-init or something similar to identify all messages sourced from this script?
yakuake-init.sh
Outdated
| then | ||
| echo "${result}" | ||
| result=$(dbus-send --print-reply=literal --dest=org.kde.yakuake /yakuake/${path} org.kde.yakuake.${method}) |
There was a problem hiding this comment.
We seem to have a difference of opinion here about whitespace ;). Please stick with the already established convention of 4 spaces per indentation level throughout the file.
yakuake-init.sh
Outdated
| "terminalIdsForSessionId") | ||
| result=$(dbus-send --print-reply=literal --dest=org.kde.yakuake /yakuake/${path} org.kde.yakuake.${method} "${parameters[@]}") | ||
| ;; | ||
| # "methodX" | "methodY") |
There was a problem hiding this comment.
These comments are no longer necessary. Please remove.
yakuake-init.sh
Outdated
|
|
||
| # if [[ -n "${result}" ]] | ||
| # then | ||
| echo "${result}" |
There was a problem hiding this comment.
Surrounding comments are no longer necessary. Please remove and adjust this line's indentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so i created some optimizations.
Maybe you want this optimizations to. ;)