Skip to content

Fix database URL null check issue and add missing ENV setting #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix database URL null check issue and add missing ENV setting #450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebde30e
Fix database URL null check issue and add missing ENV setting
Mirza-Samad-Ahmed-Baig Jul 25, 2025
0f056cf
Merge branch 'main' into fix-database-url-issue
Mirza-Samad-Ahmed-Baig Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/backend/app/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ class Settings(BaseSettings):
PROJECT_NAME: str = "Resume Matcher"
FRONTEND_PATH: str = os.path.join(os.path.dirname(__file__), "frontend", "assets")
ALLOWED_ORIGINS: List[str] = ["http://localhost:3000", "http://127.0.0.1:3000"]
SYNC_DATABASE_URL: Optional[str]
ASYNC_DATABASE_URL: Optional[str]
SESSION_SECRET_KEY: Optional[str]
SYNC_DATABASE_URL: Optional[str] = None
ASYNC_DATABASE_URL: Optional[str] = None
SESSION_SECRET_KEY: Optional[str] = None
ENV: str = "production"
DB_ECHO: bool = False
PYTHONDONTWRITEBYTECODE: int = 1

Expand Down
4 changes: 2 additions & 2 deletions apps/backend/app/core/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
class _DatabaseSettings:
"""Pulled from environment once at import-time."""

SYNC_DATABASE_URL: str = settings.SYNC_DATABASE_URL
ASYNC_DATABASE_URL: str = settings.ASYNC_DATABASE_URL
SYNC_DATABASE_URL: str = settings.SYNC_DATABASE_URL or "sqlite:///./app.db"
ASYNC_DATABASE_URL: str = settings.ASYNC_DATABASE_URL or "sqlite+aiosqlite:///./app.db"
DB_ECHO: bool = settings.DB_ECHO

DB_CONNECT_ARGS = (
Expand Down