Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gemini Ai Support #446

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

aakash-a-dev
Copy link
Contributor

@aakash-a-dev aakash-a-dev commented Nov 21, 2024

You can check Feature from here

image

Please let me know

fix: #445

@aakash-a-dev
Copy link
Contributor Author

image
image

Gemini Support Added! I am doing the lining issue for now

@aakash-a-dev
Copy link
Contributor Author

Resolved all the issue, the gemini api is working smoothly. Please do let me know in any case there could be any scope of improvement.

Copy link
Contributor

@nichochar nichochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! Will test it this weekend before merging but I think this is good to go!

@@ -20,9 +20,9 @@
"@changesets/cli": "^2.27.8",
"@srcbook/configs": "workspace:^",
"@types/node": "^20.14.2",
"eslint": "^8.57.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal but why change this order?

Copy link
Contributor Author

@aakash-a-dev aakash-a-dev Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, we can ignore this during the integration I was getting a type error which I thought could be resolved by having ai-sdk for Google installed in the root package when I later realized it has nothing to with it, I removed it from package.json for avoiding not so necessary installation in the package. And honestly I didn't realized that it changed the order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this particular commit as well btw! I don't know how it got committed because I remembered I removed the dependency, if it's possible to not align with the following package.json then it works because we have nothing to do with root's package.json file

Copy link
Contributor

@nichochar nichochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging!

@nichochar nichochar merged commit b018497 into srcbookdev:main Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Google Gemini
2 participants