Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cmake to project #4

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

JeffHough
Copy link

Thank you for putting this stl_reader together! It is working great for my needs.

Although this project is already quite simple to consume, a lot of people prefer to consume all of the dependencies through cmake. I restructured things slightly to put the header file under include/stl_reader, and added a CMakeLists.txt. This way, the stl_reader can be packaged using the usual

mkdir build && cd build
cmake ..
cmake --build .
sudo cmake --install . --prefix /some/install/prefix

This project can then be included in their other project's CMakeLists.txt file using:

find_package(stl_reader REQUIRED)
...
target_link_libraries(some_library
PUBLIC
stl_reader::stl_reader # gets included as if it were a library
)

And the header file will be available using #include <stl_reader/stl_reader.h> in any file of the consumer.

JeffHough and others added 2 commits September 14, 2022 10:42
added cmake to the stl_reader project for ease of inclusion in other projects [WIP]
@sreiter
Copy link
Owner

sreiter commented Sep 16, 2022

Hi Jeff,

thanks a lot for creating those scripts and putting the pull request up. Really appreciated!
I will take a closer look and will get back to you.

Thanks and best regards,
Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants