Changed FromComponentsInHierarchy to require scope set

ssannandeji · Oct 7, 2018 · 07100a8 · 07100a8
1 parent fc9696b
commit 07100a8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...egrationTests/Tests/Bindings/TestFromComponentInHierarchy/TestFromComponentInHierarchy.cs b/...egrationTests/Tests/Bindings/TestFromComponentInHierarchy/TestFromComponentInHierarchy.cs
@@ -58,7 +58,7 @@ public IEnumerator RunMatchMultiple()
             Setup1();
             PreInstall();
             Container.Bind<Qux>().AsSingle();
-            Container.Bind<Foo>().FromComponentsInHierarchy();
+            Container.Bind<Foo>().FromComponentsInHierarchy().AsCached();
 
             PostInstall();
 
@@ -88,7 +88,7 @@ public IEnumerator RunMatchNotFoundSuccess()
             PreInstall();
 
             Container.Bind<Qux>().AsSingle().NonLazy();
-            Container.Bind<Foo>().FromComponentsInHierarchy();
+            Container.Bind<Foo>().FromComponentsInHierarchy().AsCached();
 
             PostInstall();
 
@@ -134,7 +134,7 @@ public IEnumerator RunMatchMultipleNonGeneric()
             Setup1();
             PreInstall();
             Container.Bind<Qux>().AsSingle();
-            Container.Bind(typeof(Foo)).FromComponentsInHierarchy();
+            Container.Bind(typeof(Foo)).FromComponentsInHierarchy().AsCached();
 
             PostInstall();
 
@@ -164,7 +164,7 @@ public IEnumerator RunMatchNotFoundSuccessNonGeneric()
             PreInstall();
 
             Container.Bind<Qux>().AsSingle().NonLazy();
-            Container.Bind(typeof(Foo)).FromComponentsInHierarchy();
+            Container.Bind(typeof(Foo)).FromComponentsInHierarchy().AsCached();
 
             PostInstall();
 

diff --git a/UnityProject/Assets/Plugins/Zenject/Source/Binding/Binders/FromBinders/FromBinder.cs b/UnityProject/Assets/Plugins/Zenject/Source/Binding/Binders/FromBinders/FromBinder.cs
@@ -747,7 +747,7 @@ protected ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInHierarchy
         {
             BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);
 
-            BindInfo.RequireExplicitScope = false;
+            BindInfo.RequireExplicitScope = true;
 
             // Don't know how it's created so can't assume here that it violates AsSingle
             BindInfo.MarkAsCreationBinding = false;