Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit for-item mapping to nearest-neighbor set #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonahharris
Copy link

@jonahharris jonahharris commented Nov 1, 2022

Currently, write_indicators() iterates the vector of nearest neighbors using the index as the for_item, which is incorrect. While the ordering of operations in indicators() should ensure items_to_rescore is ordered by index accordance with item_id as generated (in FIFO order from the interactions), that appears not to be the case any longer. Instead of relying on underlying collections to be order-preserving, this instead returns a tuple with the for_item id along with the FnvHashSet of nearest neighbors from rescore().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant