Add explicit for-item mapping to nearest-neighbor set #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
write_indicators()
iterates the vector of nearest neighbors using the index as thefor_item
, which is incorrect. While the ordering of operations inindicators()
should ensureitems_to_rescore
is ordered by index accordance with item_id as generated (in FIFO order from the interactions), that appears not to be the case any longer. Instead of relying on underlying collections to be order-preserving, this instead returns a tuple with thefor_item
id along with the FnvHashSet of nearest neighbors fromrescore()
.