Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with gcc<11.2 #8

Closed

Conversation

adriendelsalle
Copy link

Description

Related to downstream project yams issue.

Fix gcc<11.2 compilation error due to std::reduce buggy implementation when using the binary functor overload (on static assertion).

  • use std::accumulate instead of std::reduce to workaround the issue
  • see gcc bug tracker for more details

use std::accumulate instead of std::reduce
@adriendelsalle
Copy link
Author

Closing according to the discussion on yams to keep the best performance possible using std::reduce and therefore require gcc>=11.2, which is also a requirement for tbb execution policy of some stl algos used.

@adriendelsalle adriendelsalle deleted the fix-gcc10-reducer branch July 4, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant