Refactor package structure #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this work, as I'm currently working on the solver it might be tough to integrate your work just now. Moreover I'm planning to add new module to this project so please before moving files maybe we can talk about it before, it will be less frustrating for both of us :) |
|
no worries, I would be happy to chat about that! |
adriendelsalle
force-pushed
the
package-structure
branch
from
7cd091a
to
2eb3349
Compare
|
I just rebased on master |
create libyams split the header-only library from the binary targets add a python package structure to install pyams make the CLI, C++ tests and python bindings rely on libyams update the conda recipe add cmake config files for downstream packages add README for build instructions add missing deps in env-dev yaml file use pre-installed libyams if lib is not built
replace incl dirs and links libs with deps on gbs targets
adriendelsalle
force-pushed
the
package-structure
branch
from
2eb3349
to
4220b85
Compare
|
I'm converting it to draft PR since last commit requires |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor package structure:
libyamsto split the header-only library from the binary targetsyamsnamespace and include subdir for C++ headerspyamsusing Python packaging tools instead ofCMake(will require topip install (-e) ./pythonto use the library)pybind11is installed in thepyamssource dirlibyamsCMakeconfig files for downstream packageslibyamsif lib is not builtREADMEfor build instructions, including flagsenvironment-dev.ymlfile.gitignore