Fix files not being correctly unzipped #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Entiendo que este error te da cuando le das a descargar en Zip la librería? |
|
Composer usa la librería unzip del sistema durante la instalación del paquete. En el entorno que he usado parece que los acentos del nombre de los documentos dan problemas. Al especificar el directorio Ignorar este tipo de archivos y directorios (tests, documentación, etc.) se considera una buena práctica. Más info aquí: https://www.reddit.com/r/PHP/comments/2jzp6k/i_dont_need_your_tests_in_my_production/?rdt=33134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola @ssheduardo,
Este PR arregla un issue durante la instalación del paquete en entornos en los que unzip no acepta acentos en los nombres de fichero.
Además, reduce el tamaño de la librería ignorando ficheros y carpetas durante la instalación con composer que no se usan en el paquete.