894 objectstore errors #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponyisi
reviewed
Dec 5, 2024
BenGalewsky
force-pushed
the
894_objectstore_errors
branch
from
aeb15ce to
e9fd65c
Compare
ponyisi
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The object store manager swallows exceptions from uploading the transformed file to the object store. When this happens
the file is not reported at all to the app and the transform will never complete.
Resolves #894
Approach
Instead of just logging the exceptions and carrying on, raise a new Exception subclass, ObjectStoreError - catch that in the transformer and post the file-complete message to the server, but with the status set to failed
Also took this opportunity to remove the vestigial UploadQueue from the class