change a regex and contents on Redirect on login chapter #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queryString()
with"redirect"
as an argument, so I think it's not necessary to use regex to escape special characters onname
variable. (and you forgot to put regex special characters in the braces)=
toresults[2]
, so it's not necessary to capture&
or#
or$
toresults[1]
.window.location.href
is encoded byencodeURI()
, notencodeURIComponent
. So, we should usedecodeURI
to decode it.Signup
component withUnauthenticatedRoute
which takes responsibility for redirecting. So we should remove a redirecting logic inSignup
to prevent conflicts.