[WIP] fix: respect SHELL environment variable on Windows for bash commands #3712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when SHELL env was set (e.g., to Git Bash), LLM-executed bash commands and user shell commands would ignore it and use cmd.exe instead.
Changes:
detection so bash.exe is correctly matched to bash invocation rules
shell: true which defaults to cmd.exe
Tested with nushell and bash.exe from Git For Windows
Required for user that using Git Bash:
C:\Program Files\Git\usr\bin\bash.exeC:\Program Files\Git\usr\binneed to be in path so the bash can use others linux utilities command.Here is the video of using with Git Bash
gitbash-test.mp4
Here is the video of using with Nushell
nushell-test.mp4