FIx path resolution - including windows

[jl4nz]

Closes #93

ps: this gave me a headache.

[netlify]

✅ Deploy Preview for sst-docs canceled.

Name	Link
🔨 Latest commit	5628336
🔍 Latest deploy log	https://app.netlify.com/projects/sst-docs/deploys/68e47d9fd2c9290009c74e86

[zack-heil-fhr]

@jayair @fwang We've got some folks in our company hitting this issue on Windows machines too and the fix here seems to get past it. Can we get this merged?

[jayair]

I'll bump internally.

[michael-schienbein-fhr]

how's this going?

[cdurante]

Any updates? The SST V2 Mainline branch is essentially broken for windows users currently waiting on this fix.

[zack-heil-fhr]

@jayair @fwang What's the best strategy for those of us that can't move lots of projects off of CDK that need to use v2 with patches moving forward? A community maintained fork?

[jl4nz]

AFIK, this is in maintenance mode and mostly patched by the community, so I would't fork it.
Just the review process depends on the authors (that maybe are busy/focused on SST Ion)... maybe we need more maintainers?

I'll try to ping someone on Discord.

[FlanaganSe]

Hey @jayair @fwang, when you have a moment could you take another look at this?
It’s been open for a while and is currently breaking our use case, preventing us from being able to update to v2.49.

If you need help testing / reviewing I or others can always help!

[fwang]

Thanks @jl4nz! Can u resolve the conflict? Let me know and i'll merge it in.

[jl4nz]

@fwang I fixed the conflicts... however, I noticed the update was to the previous MR related to try to fix the test... well, it didn't, as after the rebase I still saw the VITE error mentioned here #108

Doing a bit of research, I found some imports where odd in src/iot.ts and test/constructs/helper.ts , after those fixes, the test are running again. I pushed these fixes, so please have a look.

npm test test/constructs/Topic.test.ts                                                                                                                                
> [email protected] test
> vitest run test/constructs/Topic.test.ts


 RUN  v0.33.0 /github/sst/v2/packages/sst

 ✓ test/constructs/Topic.test.ts (27) 1639ms
   ✓ cdk.topic is imported
   ✓ cdk.topic is props
   ✓ cdk.topic: topic name does not end in .fifo
   ✓ cdk.topic: topic name ends in .fifo
   ✓ subscribers: Function string single
   ✓ subscribers: Function strings multi
   ✓ subscribers: Function construct
   ✓ subscribers: TopicFunctionSubscriberProps
   ✓ subscribers: Queue
   ✓ subscribers: TopicQueueSubscriberProps
   ✓ subscribers: empty
   ✓ subscribers: undefined
   ✓ snsSubscriptions
   ✓ snsSubscriptions: with queue subscribers
   ✓ subscriberFunctions
   ✓ subscriberFunctions: with queue subscribers
   ✓ addSubscribers: add function subscribers
   ✓ addSubscribers: add function subscribers for 2 topics
   ✓ addSubscribers: add queue subscribers
   ✓ attachPermissions
   ✓ attachPermissionsToSubscriber
   ✓ attachPermissionsToSubscriber: attach to queue subscriber
   ✓ attachPermissions-after-addSubscribers
   ✓ bind
   ✓ bindToSubscriber
   ✓ bindToSubscriber: attach to queue subscriber
   ✓ bind-after-addSubscribers

 Test Files  1 passed (1)
      Tests  27 passed (27)
   Start at  11:39:06
   Duration  11.04s (transform 955ms, setup 0ms, collect 9.05s, tests 1.64s, environment 0ms, prepare 87ms)