Local ip check update #729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues. This is because we require websocket functionality on mobile hotspots, and can't rely on DNS entries.
|
tested this today and also saved me a lot of trouble, while trying to connect via iOS on a local network (no internet). would never return the ip address in the local network, which you can view via Wifi (i) icon. |
|
Thanks for the commit, it really helped me out! You probably do want to update the pull request to use the same styling as the rest of the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to establish a websocket connection between two devices connected to the same mobile hotspot.
This means we can't reliably get a valid DNS entry for the isLocal check.
I have just added extension that will return true if a supplied IP is within the Private ranges.