Skip to content
This repository has been archived by the owner on Mar 18, 2021. It is now read-only.

Fix #899: Don't try to rename ops ids from ManagedObjectController subclasses #900

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

point-source
Copy link

Fixes #899

@point-source
Copy link
Author

Hmm seems this doesn't result in valid openapi spec under some conditions. Will continue to work on it. Don't merge yet.

@point-source point-source changed the title Fix #899: Only modify ops keys if they exist Fix #899: Don't try to rename ops ids from ManagedObjectController subclasses Oct 2, 2020
@point-source
Copy link
Author

Okay, this should be safe now. Actually maybe safer than the original implementation and I confirmed it still works with the openapi sdk generator. It is also much clearer about what it is actually doing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"document" command fails when a multi-variable path is routed to a ManagedObjectController
1 participant