Fix issue for sparse matrix conversions #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManifoldFR
reviewed
Mar 26, 2025
| @@ -156,6 +156,10 @@ void eigen_sparse_matrix_from_py_construct( | |||
| } | |||
| MapMatOrRefType sparse_map(m, n, nnz, indptr.data(), indices_ptr, data_ptr); | |||
|
|
|||
| #if EIGEN_VERSION_AT_LEAST(3, 4, 90) | |||
| sparse_map.sortInnerIndices(); | |||
There was a problem hiding this comment.
Probably at some point we would like to add a check (and throw an exception) if the indices are unsorted and the Eigen version is below 3.4.90 ?
7 tasks
|
I will open a PR on nanobind to address this issue ahead of our transition to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very nice fix @ManifoldFR ;)