Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concepts page on JVM argument overrides #697

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 2, 2025

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 8f8e78d
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/677cfda358438d0008c43b8c
😎 Deploy Preview https://deploy-preview-697--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

modules/concepts/pages/overrides.adoc Outdated Show resolved Hide resolved
modules/concepts/pages/overrides.adoc Outdated Show resolved Hide resolved
modules/concepts/pages/overrides.adoc Outdated Show resolved Hide resolved
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things.

modules/concepts/pages/overrides.adoc Outdated Show resolved Hide resolved
modules/concepts/pages/overrides.adoc Outdated Show resolved Hide resolved
modules/concepts/pages/overrides.adoc Outdated Show resolved Hide resolved
modules/concepts/pages/overrides.adoc Outdated Show resolved Hide resolved
modules/concepts/pages/overrides.adoc Outdated Show resolved Hide resolved
sbernauer and others added 2 commits January 7, 2025 11:07
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Member Author

Thanks for your quick review! The merge is blocked on the decision https://github.com/stackabletech/decisions/issues/37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants