Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KeyValuePairs' internal BTreeSet with BTreeMap #888

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 11, 2024

Description

Fixes #887

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Techassi
Techassi previously approved these changes Oct 16, 2024
@nightkr nightkr requested a review from Techassi October 16, 2024 11:35
@nightkr nightkr marked this pull request as ready for review October 16, 2024 11:35
@nightkr nightkr enabled auto-merge October 16, 2024 11:35
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in general, but maybe we should close this one in favour of #889?

@nightkr nightkr added this pull request to the merge queue Oct 16, 2024
@Techassi Techassi removed this pull request from the merge queue due to a manual request Oct 16, 2024
@nightkr
Copy link
Member Author

nightkr commented Oct 16, 2024

Depends. #889 breaks a lot of the API, so I'd prioritize getting the smaller fix in to avoid delaying the rest of the release.

@Techassi
Copy link
Member

Alright, makes sense. Let's delay #889 until the 24.11 release is done.

@Techassi Techassi added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 82a0ef6 Oct 17, 2024
10 checks passed
@Techassi Techassi deleted the bugfix/kvp-duplication branch October 17, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

KeyValuePairs::extend implements a nonsense merge
2 participants