Conversation
Contributor
Author
|
It works:tm:, still need to do docs and configuration. |
Contributor
Author
|
Not sure how to test this properly, "just let the test wait for two years" obviously isn't a viable strategy. We could at least test certificate selection by setting up some static certificates in the test suite, but having them be completely static wouldn't work either (since the correct certificate to choose depends on the system time). |
6 tasks
sbernauer
requested changes
Jan 29, 2024
Member
sbernauer
left a comment
There was a problem hiding this comment.
Great work! Tested manually by lowering the constant times and successfully rolled over 👍
sbernauer
reviewed
Jan 29, 2024
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
…-operator into feature/ca-rotation
Contributor
Author
|
Created #355 for the testing. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #93
Definition of Done Checklist