Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Version CRD #597

Merged
merged 18 commits into from
Mar 19, 2025
Merged

chore: Version CRD #597

merged 18 commits into from
Mar 19, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Feb 12, 2025

Description

Part of stackabletech/issues#642

--- PASS: kuttl (750.67s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/resources_superset-latest-4.1.1_openshift-false (103.78s)
        --- PASS: kuttl/harness/cluster-operation_superset-latest-4.1.1_openshift-false (117.03s)
        --- PASS: kuttl/harness/logging_superset-4.0.2_openshift-false (185.71s)
        --- PASS: kuttl/harness/ldap_superset-4.1.1_ldap-authentication-server-verification-tls_openshift-false (137.80s)
        --- PASS: kuttl/harness/ldap_superset-4.1.1_ldap-authentication-no-tls_openshift-false (124.60s)
        --- PASS: kuttl/harness/ldap_superset-4.1.1_ldap-authentication-insecure-tls_openshift-false (100.91s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-server-verification-tls_openshift-false (103.86s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-no-tls_openshift-false (104.41s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-insecure-tls_openshift-false (101.61s)
        --- PASS: kuttl/harness/smoke_superset-4.1.1_openshift-false (96.96s)
        --- PASS: kuttl/harness/logging_superset-4.1.1_openshift-false (115.13s)
        --- PASS: kuttl/harness/oidc_superset-4.1.1_openshift-false (137.10s)
        --- PASS: kuttl/harness/oidc_superset-4.0.2_openshift-false (123.61s)
        --- PASS: kuttl/harness/smoke_superset-4.0.2_openshift-false (98.51s)
        --- PASS: kuttl/harness/druid-connection_superset-4.1.1_openshift-false (192.16s)
        --- PASS: kuttl/harness/druid-connection_superset-4.0.2_openshift-false (184.04s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@xeniape xeniape self-assigned this Feb 12, 2025
@xeniape xeniape marked this pull request as ready for review February 12, 2025 09:01
@NickLarsenNZ NickLarsenNZ self-requested a review February 12, 2025 14:12
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changes around the imports are required.

@xeniape xeniape requested a review from NickLarsenNZ February 17, 2025 12:44
@xeniape xeniape requested a review from Techassi February 24, 2025 12:10
NickLarsenNZ
NickLarsenNZ previously approved these changes Feb 25, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a question about some un-versioned types.

@sbernauer
Copy link
Member

Currently waiting for kube-rs/kube#1704

@xeniape xeniape requested a review from Techassi March 18, 2025 09:34
@xeniape xeniape requested a review from NickLarsenNZ March 18, 2025 09:34
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, two small comments.

@xeniape xeniape requested a review from Techassi March 18, 2025 11:55
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit c7273b5 Mar 19, 2025
17 checks passed
@xeniape xeniape deleted the chore/add-crd-versioning branch March 19, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants