-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Trino 470 #705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation LGTM, many thanks!
It would be great if you could please add some docs for the user. Maybe below https://docs.stackable.tech/home/stable/trino/#_supported_versions? Or put it somewhere else and link to it there.
IMHO it should contain a quick explanation that Trino switches it's S3 implementation and link to trinodb/trino#24878.
Also mention that users can roll back to the legacy using this and that configOverrides, however that it will be removed eventually.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for driving this!
Improve error message
Emit warning only if tls is disabled.
This is not ideal as it prevents people trying whatever version they want, but we will defer this to a team decision later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR!
Only small things left
Co-authored-by: Sebastian Bernauer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks!
Description
Part of stackabletech/docker-images#999.
Definition of Done Checklist
Author
Reviewer
Acceptance