Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Trino 470 #705

Merged
merged 38 commits into from
Mar 11, 2025
Merged

feat: Add support for Trino 470 #705

merged 38 commits into from
Mar 11, 2025

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Feb 5, 2025

Description

Part of stackabletech/docker-images#999.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM, many thanks!

It would be great if you could please add some docs for the user. Maybe below https://docs.stackable.tech/home/stable/trino/#_supported_versions? Or put it somewhere else and link to it there.
IMHO it should contain a quick explanation that Trino switches it's S3 implementation and link to trinodb/trino#24878.
Also mention that users can roll back to the legacy using this and that configOverrides, however that it will be removed eventually.

Thanks!

@sbernauer sbernauer changed the title feat: Add support for Trino 469 feat: Add support for Trino 470 Feb 10, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving this!

NickLarsenNZ and others added 2 commits February 25, 2025 10:40
Improve error message
Emit warning only if tls is disabled.
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR!
Only small things left

@NickLarsenNZ NickLarsenNZ requested a review from sbernauer March 11, 2025 10:28
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@NickLarsenNZ NickLarsenNZ enabled auto-merge March 11, 2025 18:49
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Mar 11, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Mar 11, 2025
Merged via the queue into main with commit 2f846bc Mar 11, 2025
16 of 17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the bump/trino-469 branch March 11, 2025 18:53
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants