Update electron to v24 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzulfikar
commented
Apr 11, 2023
There was a problem hiding this comment.
This file is not really necessary for this PR. But this is the version I use that I'm sure will work.
wzulfikar
commented
Apr 11, 2023
There was a problem hiding this comment.
I use pnpm to run the repo (but tested with npm install too). Happy to remove and replace with package-lock.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking the Electron course at Udemy (https://www.udemy.com/course/master-electron) and the electron was far behind current version.
npm installis broken because some assets are missing. Example:I didn't think that just updating the electron would work, but it did! This PR updates the electron from v9 to v24. Running
npm installnow works:and here's the electron window that's triggered when running
npm start: