Skip to content

Fix test error and add yuzp1996 to default_data.json #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuzp1996 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix test error and add yuzp1996 to default_data.json #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions default_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36522,6 +36522,17 @@
"user_name": "Wenzhi Yu",
"emails": ["[email protected]", "[email protected]"]
},
{
"github_id": "yuzp1996",
"companies": [
{
"company_name": "Alauda",
"end_date": null
}
],
"user_name": "yuzhipeng",
"emails": ["[email protected]", "[email protected]", "[email protected]"]
},
{
"github_id": "yxpoke",
"companies": [
Expand Down
7 changes: 1 addition & 6 deletions tests/test_config_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import functools
import json

import jsonschema
import six
import testtools

DEFAULT_DATA_JSON_PATH = 'default_data.json'
Expand Down Expand Up @@ -50,10 +48,7 @@ def dict_raise_on_duplicates(ordered_pairs):
class TestConfigFiles(testtools.TestCase):

def _read_raw_file(self, file_name):
if six.PY3:
opener = functools.partial(open, encoding='utf8')
else:
opener = open
opener = open
with opener(file_name, 'r') as content_file:
return content_file.read()

Expand Down