-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: bzlmod reprise #382
base: master
Are you sure you want to change the base?
WIP: bzlmod reprise #382
Conversation
* remove repo_name for gazelle and rules_go * restore go.sum --------- Co-authored-by: Ankur Mehta <[email protected]>
In case it helps anyone, I've also been interested in this project and when I saw more activity here I attempted to upgrade my project's WORKSPACE dependency of this repo to the current bzlmod latest in this branch (62a16a3 as of writing) I ended up having some issues with the javascript and grpc_web deps, but was able to resolve for my use case by making this patch (also forked here) and specifying the same bazel_dep(name = "build_stack_rules_proto")
git_override(
module_name = "build_stack_rules_proto",
remote = "https://github.com/stackb/rules_proto.git",
commit = "62a16a36c1e1092a0c55767de6c5c574a5ebf13e", # WIP upstream bzlmod branch pcj/bzlmod-wip
# patch upstream to fix protobuf_javascript and grpc_web deps
# see also: https://github.com/stackb/rules_proto/pull/382#issuecomment-2669653947
patches = ["//:patches/stackb.patch"],
patch_strip = 1,
)
# overriding build_stack_rules_proto~protobuf_javascript
git_override(
module_name = "protobuf_javascript",
commit = "5d939dbc8fd5245c4316d52c203a1bff24bac5c4", # https://github.com/protocolbuffers/protobuf-javascript/commit/05560593d93e7207e84829b3ab6a80c08078e389
remote = "https://github.com/protocolbuffers/protobuf-javascript",
) Obviously not ideal compared to having Interestingly, I also had to comment out Bonus patch for a dangling reference to |
No description provided.