feat(astro): custom expressive code plugins #444
Merged
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
isaacplmann
force-pushed
the
expressive-code-plugins
branch
from
01fdcc6 to
f1fecff
Compare
AriPerkkio
approved these changes
Apr 12, 2025
There was a problem hiding this comment.
Thanks, looks good! 💯
I'll got to check why the e2e tests are breaking. Looks like unzipping the downloaded project fails now. Probably related to recent Webcontainer Node 20 upgrades (cc. @SamVerschueren) 🤔
|
@AriPerkkio I tested the same code on StackBlitz and it seems to work fine (https://stackblitz.com/~/edit/node-wpdcdazw?file=index.js). The zip I used is downloaded from Bolt and thus uses the same export functionality as TutorialKit. So not entirely sure what goes wrong... |
Created #447 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add custom expressive code plugins to change the way code blocks are rendered.
This PR adds an options
expressiveCodePluginsproperty on thetutorialkitplugin that is instantiated in theastro.config.ts.