Each NODE_VERSION is responsible for building its own prebuilt binary

This is to potentially work around the openssl_fips variable issue with node-gyp
stackgl · Oct 10, 2022 · efd4aa3 · efd4aa3
1 parent ffcc4b5
commit efd4aa3
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -6,12 +6,34 @@ env:
     - secure: "MHkBPTRLhQ04GgdBNOJvvvHf7gJyrc9aWCznWipB2RUQG+vobxPuOCV+rFFUB4Z/q3Dh54d/61dHs9nwHW/uP1jStwPqW1x19Uhcny+c0WEY6A87wjnUVR4g7pQ7+vzkwg8o2jdBC+8BQ/4M4IQ2nRic5qcB8Z6FCOdL4ENhvA8="
 matrix:
   include:
+  - os: linux
+    sudo: required
+    dist: focal
+    compiler: g++
+    env:
+      - NODE_VERSION=14
+  - os: linux
+    sudo: required
+    dist: focal
+    compiler: g++
+    env:
+      - NODE_VERSION=16
   - os: linux
     sudo: required
     dist: focal
     compiler: g++
     env:
       - NODE_VERSION=18
+  - os: osx
+    osx_image: xcode13.4
+    compiler: clang
+    env:
+      - NODE_VERSION=14
+  - os: osx
+    osx_image: xcode13.4
+    compiler: clang
+    env:
+      - NODE_VERSION=16
   - os: osx
     osx_image: xcode13.4
     compiler: clang

diff --git a/scripts/after_success.sh b/scripts/after_success.sh
@@ -11,12 +11,13 @@ fi
 
 COMMIT_MESSAGE=$(git show -s --format=%B $TRAVIS_COMMIT | tr -d '\n')
 PACKAGE_JSON_VERSION=$(node -e "console.log(require('./package.json').version)")
+PREBUILD_TARGET="${NODE_VERSION}.0.0"
 
 if [[ ${COMMIT_MESSAGE} == ${PACKAGE_JSON_VERSION} ]]; then
   echo "running prebuild"
-  node ./node_modules/prebuild/bin.js -t 14.0.0 -t 16.0.0 -t 18.0.0 --strip -u ${GITHUB_TOKEN}
+  node ./node_modules/prebuild/bin.js -t ${PREBUILD_TARGET} --strip -u ${GITHUB_TOKEN}
 
   if [[ ${TRAVIS_OS_NAME} == "linux" ]]; then
-    node ./node_modules/prebuild/bin.js --libc=musl -t 16.0.0 -t 18.0.0 --strip -u ${GITHUB_TOKEN}
+    node ./node_modules/prebuild/bin.js --libc=musl -t ${PREBUILD_TARGET} --strip -u ${GITHUB_TOKEN}
   fi
 fi