remove redundant volume group task

stackhpc · May 12, 2020 · c75e6b0 · c75e6b0
1 parent 366749d
commit c75e6b0
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 18 deletions.
diff --git a/README.md b/README.md
@@ -81,7 +81,7 @@ installed.
 Dependencies
 ------------
 
-None
+* [The LVM role](https://github.com/mrlesmithjr/ansible-manage-lvm) You can install it using `ansible-galaxy install -r requirements.yml --roles-p ../community`
 
 Example Playbook
 ----------------
@@ -91,6 +91,11 @@ Example Playbook
       hosts: all
       roles:
         - role: stackhpc.libvirt-host
+          lvm_groups: # see according properties on [The LVM role](https://github.com/mrlesmithjr/ansible-manage-lvm)
+            - vgname: libvirtvg
+              disks:
+                - /dev/sdb1
+              create: true
           libvirt_host_pools:
             - name: my-pool
               type: dir
@@ -101,10 +106,7 @@ Example Playbook
               group: my-group
             - name: lvm_pool
               type: lvm2
-              source: vg1
-              target: /dev/vg1
-              pvs:
-                - /dev/sda3
+              source: libvirtvg
           libvirt_host_networks:
             - name: br-example
               mode: bridge

diff --git a/molecule/default/converge.yml b/molecule/default/converge.yml
@@ -4,11 +4,10 @@
   vars:
     manage_lvm: true
     lvm_groups:
-      - vgname: libvirtpool
+      - vgname: libvirt_vg
         disks:
           - /dev/sdb1
         create: true
-        lvnames: []
     users_group_list:
       - name: libvirt
     systemusers_user_list:
@@ -18,7 +17,7 @@
     libvirt_host_pools:
       - name: libvirt_vg
         type: lvm2
-        source: libvirtpool
+        source: libvirt_vg
     libvirt_host_networks:
       - name: ansible-virtualization-bridge
         mode: bridge

diff --git a/molecule/default/tests/__pycache__/conftest.cpython-38-pytest-5.4.1.pyc b/molecule/default/tests/__pycache__/conftest.cpython-38-pytest-5.4.1.pyc
diff --git a/molecule/default/tests/__pycache__/test_default.cpython-38-pytest-5.4.1.pyc b/molecule/default/tests/__pycache__/test_default.cpython-38-pytest-5.4.1.pyc
diff --git a/molecule/kvm/converge.yml b/molecule/kvm/converge.yml
@@ -4,11 +4,10 @@
   vars:
     manage_lvm: true
     lvm_groups:
-      - vgname: libvirtpool
+      - vgname: libvirt_vg
         disks:
           - /dev/vdb
         create: true
-        lvnames: []
     users_group_list:
       - name: libvirt
     systemusers_user_list:

diff --git a/tasks/pools.yml b/tasks/pools.yml
@@ -18,14 +18,6 @@
   with_items: "{{ libvirt_host_pools }}"
   become: True
 
-- name: Ensure libvirt lvm2 storage pool directories exist
-  lvg:
-    vg: "{{ item.source }}"
-    pvs: "{{ item.pvs }}"
-  when: item.type == "lvm2" and item.pvs is defined
-  with_items: "{{ libvirt_host_pools }}"
-  become: True
-
 - name: Ensure libvirt storage pools are defined
   virt_pool:
     name: "{{ item.name }}"