Add helm chart with initial functional test #2
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
The problem with Django more generally is that the documentation assumes you have one settings file, but there are actually two classes of settings:
In Azimuth, we use https://github.com/stackhpc/django-flexi-settings to allow us to break up the settings file in this way. If we are going to stick with Django, I think it is worth doing something similar here. |
Add Tilt component
| # Not doing so means that AWX-related keys are not removed on transition to the CRD | ||
| data: | ||
| 01-django.yaml: | | ||
| {{- tpl (.Files.Get "files/settings/01-django.yaml") . | b64enc | nindent 4 }} |
There was a problem hiding this comment.
Personally, for the number of settings you have I would just inline them here.
There was a problem hiding this comment.
might just leave it as it is as we will probably add configuration in the future
| DATABASES = { | ||
| "default": { | ||
| "ENGINE": "django.db.backends.sqlite3", | ||
| "NAME": "/data/db.sqlite3", | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe this should be in the settings in the chart values, so it is easier to change to point at a proper DB in future?
There was a problem hiding this comment.
made database configurable via values now
|
@mkjpryor huh, for some reason when I first tried this I was getting some permissions errors about service accounts, which I can't remember exactly by memory. But removed it now and it still works 🤷 |
* Dockerfile * initial CI setup * initial helm charts * add functional test * make database configurable, with default --------- Co-authored-by: Jake Hutchinson <[email protected]>
No description provided.