Ingress configuration in Helm chart

[assumptionsandg]

No description provided.

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[scrungus]

you need to define this in helpers.tpl (and allow override from values.yaml)

[scrungus]

It would be nice for the functional test to reflect this. I guess that would involve adding an nginx onto the kind cluster

[scrungus]

I think you might need something like:

{{- with .Values.ingress.annotions }}
  annotations: {{ toYaml . | nindent 4 }}
  {{- end }}

[scrungus]

Can you adapt the functional test as well to install an nginx ingress controller and test this endpoint instead of the current port forwarding?

You should be able to just add a helm command that replicates the functionality of azimuth-ops:
https://github.com/stackhpc/ansible-collection-azimuth-ops/blob/500e98bc4ff8c93e8a75207f9908e483a737c866/roles/ingress_nginx/tasks/main.yml#L3-L14

[scrungus]

* Ingress.extensions "coral-credits" is invalid: spec.tls[0].hosts[0]: Invalid value: "": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

I think this will get fixed when you configure nginx and inject values in the functional test

[scrungus]

@assumptionsandg this may be useful to look at https://kind.sigs.k8s.io/docs/user/ingress/.

also I normally use https://github.com/lhotari/action-upterm for debugging issues in actions

[JohnGarbutt]

Lets hard code this to "/" I think?

[JohnGarbutt]

Lets remove the path config for now, I think, keep it simple.

[JohnGarbutt]

can we not call this http?

[scrungus]

LGTM