Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail if GitHub PR creation fails #39

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fail if GitHub PR creation fails #39

merged 1 commit into from
Sep 27, 2023

Commits on Sep 27, 2023

  1. Fail if GitHub PR creation fails 

    GitHub pull request creation can fail for various reasons [1], and
should return a 4XX code if it does.

Previously the response code was ignored (the default behaviour of
curl), so PR creation could silently fail. This change adds the curl
--fail argument, as is used for Gitlab.

[1] https://docs.github.com/en/free-pro-team@latest/rest/pulls/pulls?apiVersion=2022-11-28#create-a-pull-request--status-codes
    @markgoddard
    markgoddard committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    deba199 View commit details
    Browse the repository at this point in the history