-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally allow SKC checkout to persist #41
Conversation
Just for full context on why this is useful, I'm using this as part of a workflow to check octavia cert expiry. This needs the KA config generated so the certs are in the location (kayobe-config/etc/kolla/config/octavia) that KA checks for.
|
Looks reasonable. Annoying that the github checkout action can't clone to an absolute path, otherwise we could clone to /home/stack/kayobe-automation-env/src/kayobe-config and achieve the same effect. Alternative would be to checkout and then copy to /home/stack/kayobe-automation-env/src/kayobe-config. See: actions/checkout#197 |
Adds a flag to allow the current copy of kayobe-config to be used, rather than copying in a clean version. This is useful if you want to use previously-generated Kolla config under kayobe-config/etc/kolla
0daed2e
to
cc5cb24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change has introduced an issue whereby all attempts to run kayobe-automation yield the following error.
I think this should amendmended such that the original behaviour is the default. |
Ah this was meant to be the intention. Looks like I messed it up when changing from "true/false" to "1/0". |
PR to fix here: #43 |
Adds a flag to allow the current copy of kayobe-config to be used, rather than copying in a clean version.
This is useful if you want to use previously-generated Kolla config under kayobe-config/etc/kolla