feat: add support for exceptions to annotations #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some secrets when redacted are rejected due to invalid characters. One example of this would `prometheus_bcrypt_salt` which is rejected due to the use of underscores. Therefore the solution is to add support for exceptions to the standard annotation format. See: https://github.com/ansible/ansible/blob/devel/lib/ansible/utils/encrypt.py#L118C46-L118C46
jackhodgkiss
force-pushed
the
salt_redact_fix
branch
from
2c8db41
to
84ee860
Compare
MaxBed4d
previously approved these changes
Dec 29, 2023
markgoddard
reviewed
Jan 3, 2024
jackhodgkiss
force-pushed
the
salt_redact_fix
branch
from
aa8ec22
to
4ee379d
Compare
|
Most recent change ensures that nested dicts are redacted and still keep the full name. becomes |
jackhodgkiss
force-pushed
the
salt_redact_fix
branch
from
4ee379d
to
6feb7f6
Compare
In addition to bcrypt salt rejecting underscores amongst other characters it must also be exactly 22 characters long.
jackhodgkiss
force-pushed
the
salt_redact_fix
branch
from
6feb7f6
to
024b83e
Compare
jovial
approved these changes
May 16, 2024
|
LGTM - nice solution :) |
|
@jackhodgkiss Is this planned to merge soon? |
|
Happy to merge it now. It was working last time I checked but don't have time this week to test again. However, if you encounter any issues please let me know. |
assumptionsandg
pushed a commit
that referenced
this pull request
Nov 11, 2024
feat: add support for exceptions to annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some secrets when redacted are rejected due to invalid characters. One example of this would
prometheus_bcrypt_saltwhich is rejected due to the use of underscores. Therefore the solution is to add support for exceptions to the standard annotation format.See: https://github.com/ansible/ansible/blob/devel/lib/ansible/utils/encrypt.py#L118C46-L118C46
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/prometheus/templates/prometheus-web.yml.j2#L3